Open
Conversation
Collaborator
Author
|
Test failures appear to be related to the updated CWMS DB schema / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on #1685
Improve unfiltered /timeseries read performance + perf coverage
/timeseriesread path off the Oracleretrieve_ts_out_tabhot path and onto directAV_TSV_DQU/jOOQ reads while preservingretrieve_tsresponse semantics in JavaBenchmark
Local single-request benchmarks against the Docker/Testcontainers Oracle dev environment, using
page-sizeequal to the requested row count:250000points:40.679s250000points:4.652501s500000points:HTTP 500The current Java benchmark harness also confirms the direct path now returns the expected count for the large seeded series:
250000points:250000reported rows, correct final timestamp,4.652501sThe benchmark task writes JSON artifacts under
load_data/performance/results/.Validation
./gradlew :cwms-data-api:integrationTests --tests cwms.cda.api.TimeSeriesDirectReadParityIT./gradlew :cwms-data-api:timeseriesReadBenchmark -Pbenchmark.pointCount=250000 -Pbenchmark.runs=1 -Pbenchmark.forceReseed=trueNotes
/timeseriesread path;/timeseries/filteredis still on the legacy pathSeeding 250,000 TS values for SPK and reading them back via CDA returns in
4.6sBefore changes
Changes